Awesome-omni-skill kramme:connect:modernize-angular
Use this Skill when working in the Connect monorepo and needing to modernize legacy Angular components.
install
source · Clone the upstream repo
git clone https://github.com/diegosouzapw/awesome-omni-skill
Claude Code · Install into ~/.claude/skills/
T=$(mktemp -d) && git clone --depth=1 https://github.com/diegosouzapw/awesome-omni-skill "$T" && mkdir -p ~/.claude/skills && cp -r "$T/skills/development/kramme-connect-modernize-angular" ~/.claude/skills/diegosouzapw-awesome-omni-skill-kramme-connect-modernize-angular && rm -rf "$T"
manifest:
skills/development/kramme-connect-modernize-angular/SKILL.mdsource content
Connect - Modernize Legacy Angular Component
Instructions
When to use this skill:
- You're working in the Connect monorepo
- You need to refactor legacy Angular components to modern patterns
- Component extends legacy
orFormComponentBaseComponent - Component uses
decorators for state management@Select - Component uses
instead of typedFormNodeFormGroup - Component doesn't use
ChangeDetectionStrategy.OnPush - Component has manual subscription management
- Component dispatches actions directly instead of using ComponentStore
Context: Connect's frontend is modernizing Angular components to use NgRx ComponentStore for state management, OnPush change detection, standalone components, and proper TypeScript typing. This provides better type safety, performance, and maintainability.
Guideline Keywords
- ALWAYS — Mandatory requirement, exceptions are very rare and must be explicitly approved
- NEVER — Strong prohibition, exceptions are very rare and must be explicitly approved
- PREFER — Strong recommendation, exceptions allowed with justification
- CAN — Optional, developer's discretion
- NOTE — Context, rationale, or clarification
- EXAMPLE — Illustrative example
Strictness hierarchy: ALWAYS/NEVER > PREFER > CAN > NOTE/EXAMPLE
Reference Implementation
- ALWAYS refer to the Q&A components refactoring as the reference implementation:
- Edit topic component with form managementlibs/connect/cms/qa/feature/src/lib/edit-topic/
- Settings page with conditional form logiclibs/connect/cms/qa/feature/src/lib/settings-page/
- Topics page with complex statelibs/connect/cms/qa/feature/src/lib/topics-page/
Migration Process
Phase 1: Assessment
-
ALWAYS read all component files before starting:
- Component TypeScript file
- Component template
- Component styles (if any)
- Related store/state files
-
ALWAYS identify patterns to migrate:
- Legacy base class usage (
,extends FormComponent
)extends BaseComponent
decorators for state@Select
usageFormNode- Manual subscriptions (
,subscribe()
)takeUntil() - Direct action dispatching
- Lifecycle hooks (
vsonInit()
)ngOnInit()
- Legacy base class usage (
-
ALWAYS identify business logic:
- Form management
- State updates
- API calls
- Conditional field logic
- User interactions
Phase 2: Create ComponentStore
- ALWAYS create the store file in the same directory as the component (e.g.,
)component-name.store.ts - ALWAYS define form controls interface separately from state
- ALWAYS define forms as class properties, NOT in state
- ALWAYS extract
as a constantinitialState - ALWAYS use
for immutabilityreadonly - ALWAYS use ECMAScript
for encapsulation#privateFields - ALWAYS use proper type narrowing in effects with filter:
(tuple): tuple is [void, DataType] => tuple[1] !== null - ALWAYS use
directly in effects:pipe()
notthis.effect<Type>(pipe(...))this.effect<Type>((param$) => param$.pipe(...))
EXAMPLE: See
resources/examples/component-store.ts for a complete ComponentStore reference implementation.
Phase 3: Refactor Component
- ALWAYS add
ChangeDetectionStrategy.OnPush - ALWAYS add
standalone: true - ALWAYS add ComponentStore to
arrayproviders - ALWAYS use
for dependency injectioninject() - ALWAYS place all
calls first in the class as readonly fieldsinject() - ALWAYS use ECMAScript
syntax for private members#privateField - NEVER use the
orpublic
keywords in TypeScriptprivate - ALWAYS remove base class extensions
- ALWAYS remove
decorators@Select - ALWAYS remove manual subscriptions
- ALWAYS remove
andDestroyRef
(ComponentStore handles cleanup)takeUntilDestroyed
EXAMPLE: See
resources/examples/component.ts for a complete component reference implementation.
Phase 4: Update Template
- ALWAYS use native control flow (
,@if
,@for
) instead of@switch
,*ngIf
,*ngFor*ngSwitch - ALWAYS use the
directive or*ngrxLet
pipe to handle ObservablesngrxPush- ALWAYS prefer the
pipe overngrxPush
for one-off async bindingsasync - PREFER not using
or*ngrxLet
multiple times for the same Observable; instead assign it to a template variable usingngrxPush@let
- ALWAYS prefer the
- PREFER adding animations for conditional UI
- ALWAYS use form bindings with proper type checking
EXAMPLE: See
resources/examples/template.html for native control flow and form binding examples.
Phase 5: UX Enhancements
Confirmation Modals
- ALWAYS add confirmation modals for destructive actions
- ALWAYS use MatDialog to open modals
- ALWAYS subscribe to
and only proceed if confirmedafterClosed()
EXAMPLE:
deleteItem(): void { this.#dialog .open(ConfirmDeleteModalComponent, { data: { itemName: this.data$.value?.name }, }) .afterClosed() .subscribe((confirmed) => { if (confirmed) { this.#componentStore.deleteItem(); } }); }
User Feedback
- ALWAYS use
in ApiAction definitions (not manual toasts in stores)successMessage - ALWAYS use
only for local operations (cancel, info messages)CoSnackService - NEVER show success before API call completes
EXAMPLE - Success Messages:
// ❌ WRONG - shows before API completes readonly saveChanges = this.effect<void>( pipe( tap(() => { this.#store.dispatch(updateAction.start(this.form.getRawValue())); this.#snacks.success('Saved!'); // ← BAD }) ) ); // ✅ CORRECT - shows only on actual success export const updateAction = new ApiAction<State, Input, Output>( 'Entity', 'Update', 'Feature', { showErrors: true, successMessage: 'Saved!', // ← GOOD } );
Copy to Clipboard
- PREFER adding copy-to-clipboard buttons for IDs
EXAMPLE:
<button matSuffix mat-icon-button matTooltip="Copy to clipboard" [cdkCopyToClipboard]="form.controls.id.value" (cdkCopyToClipboardCopied)="onIdCopied($event)" > <fa-icon [icon]="copyIcon" /> </button>
Phase 6: Verification
- ALWAYS run lint:
corepack yarn nx lint <library-name> - ALWAYS check for:
- No manual subscriptions in components
- All effects use
directlypipe() - Forms have proper type annotations
- No
typesany - Proper change detection strategy
- ALWAYS test:
- Form initialization
- Save/cancel flows
- Conditional field logic
- Error handling
- User feedback
Common Patterns
See
resources/patterns.md for detailed examples of conditional field disabling and nonNullable form controls.
Critical Rules
Forms
- NEVER store forms in ComponentStore state
- ALWAYS define forms as class properties in the store
- ALWAYS add
to form controlsnonNullable: true - ALWAYS use typed
andFormGroup
(notFormControl
)FormNode - ALWAYS define form controls interface
Effects
- ALWAYS use
directly:pipe()this.effect<Type>(pipe(...)) - NEVER use arrow functions:
this.effect<Type>((param$) => param$.pipe(...)) - ALWAYS use proper type narrowing with filter
Subscriptions
- NEVER use manual subscriptions in components
- NOTE: ComponentStore handles cleanup automatically
- NEVER use
andDestroyRef
for ComponentStore subscriptionstakeUntilDestroyed - ALWAYS wire observables directly to updaters/effects
User Feedback
- NEVER show success toasts before API calls complete
- ALWAYS use
in ApiAction definitionssuccessMessage - ALWAYS use
only for local operationsCoSnackService
TypeScript
- NEVER use
typesany- ALWAYS use
when type is uncertainunknown
- ALWAYS use
- ALWAYS use ECMAScript
syntax for encapsulation#privateField - NEVER use the
orpublic
keywords in TypeScript class membersprivate
State Management
- NEVER use
ComponentStore.get()- ALWAYS read state via selectors
- NEVER keep empty effects
Migration Checklist
See
resources/checklist.md for the full phase-by-phase migration checklist.
Additional Best Practices from AGENTS.md
- ALWAYS check AGENTS.md for the latest definite best practices
Angular Components
- ALWAYS set
inchangeDetection: ChangeDetectionStrategy.OnPush
decorator for new components@Component - ALWAYS use separate HTML files (do NOT use inline templates)
- ALWAYS place all
calls first in the class as readonly fieldsinject() - ALWAYS place
and@Input
properties second in the class@Output - ALWAYS use
bindings instead ofclassngClass - ALWAYS use
bindings instead ofstylengStyle - ALWAYS use pipes for data transformation in templates, not methods in the component class
UI and Styling
- PREFER Angular Material/CDK for complex, interactive UI
- NEVER override internal APIs in Angular Material components
- ALWAYS use Tailwind for layout, spacing, and simple styling
- ALWAYS use
prefix (enforced intw-
)libs/co/ui-tailwind-preset/tailwind.config.js - ALWAYS define repeated patterns in CSS layer using
directive@apply
FontAwesome Icons
- ALWAYS use FontAwesome icons via the
package@fortawesome/angular-fontawesome - ALWAYS use
component, not<fa-icon>
tags with CSS classes<i> - ALWAYS import from
(not free packages)@fortawesome/pro-*-svg-icons - ALWAYS store icons as readonly component properties; prefer regular style by default
Before Submitting Code Review
- ALWAYS ensure all affected tests pass locally
- ALWAYS run formatting:
(fromyarn run format
)Connect/ng-app-monolith - ALWAYS run linting:
yarn exec nx affected --targets=lint,test --skip-nx-cache - ALWAYS verify no linting errors are present
- ALWAYS ensure code follows established patterns as outlined in AGENTS.md
Reference Files
ALWAYS refer to these files for complete examples:
libs/connect/cms/qa/feature/src/lib/edit-topic/cms-qa-edit-topic.store.tslibs/connect/cms/qa/feature/src/lib/settings-page/cms-qa-settings-page.store.tslibs/connect/cms/qa/feature/src/lib/topics-page/cms-qa-topics-page.store.ts
- Angular Development Patterns sectionAGENTS.md
Examples
See the Instructions section.