Claude-skill-registry game-systems-code-review
Review code changes for game/engine systems with a focused Game Systems Engineer mindset. Use when the user asks to review code, check consistency, or validate changes against AGENTS.md standards, especially for C++ engine, threading, performance, or systems behavior.
install
source · Clone the upstream repo
git clone https://github.com/majiayu000/claude-skill-registry
Claude Code · Install into ~/.claude/skills/
T=$(mktemp -d) && git clone --depth=1 https://github.com/majiayu000/claude-skill-registry "$T" && mkdir -p ~/.claude/skills && cp -r "$T/skills/data/game-systems-code-review" ~/.claude/skills/majiayu000-claude-skill-registry-game-systems-code-review && rm -rf "$T"
manifest:
skills/data/game-systems-code-review/SKILL.mdsource content
Game Systems Code Review
Overview
Perform focused code reviews for game/engine systems, emphasizing correctness, performance, threading safety, and adherence to AGENTS.md standards.
Workflow
1. Intake and scope
- Ask for the diff/PR scope if not provided, or identify it via
/targeted files.git diff - Confirm the standards source: read
in the repo root for required patterns and constraints.AGENTS.md - Identify the subsystem(s) involved (engine loop, AI, input, resource, world, etc.).
2. Review focus areas (Game Systems Engineer lens)
- Correctness and regressions: fixed timestep behavior, update/render sequencing, deterministic ordering.
- Threading and safety: no background rendering, no static vars in threaded code, ThreadSystem usage.
- Performance: avoid per-frame allocations, reuse buffers, reserve capacity, batch where expected.
- API and ownership:
vsstd::string_view
, RAII, smart pointers, lifetime safety.std::string - Consistency with architecture: manager patterns, buffer swaps, event batching, camera usage.
- Platform pitfalls: SDL subsystem cleanup pattern, cross-platform guards, SDL boundary usage.
- Style and naming: Allman braces, C++20, naming conventions, header/inline rules.
3. Findings output format
Use a code-review-first response:
- Findings ordered by severity with file/line references.
- Call out behavior regressions, race risks, or perf traps before style issues.
- If no findings, say so explicitly and mention remaining risks or testing gaps.
- Include open questions/assumptions after findings.
- Provide a brief change summary only after findings.
4. Testing suggestions
Recommend targeted tests relevant to the changes (unit, system, or scripts). Do not run tests unless asked.
Notes
- Prefer minimal, concrete recommendations over broad refactors.
- Avoid modifying code; focus on review and guidance.
- If the user only says “review my changes,” ask which files/PR or use
to scope.git diff