OpenSkillIndex← back to search
claude-codeopenclawdevelopment

Skills swift-testing-code-review

Reviews Swift Testing code for proper use of #expect/#require, parameterized tests, async testing, and organization. Use when reviewing .swift files with import Testing, @Test, #expect, @Suite, or confirmation patterns.

install
source · Clone the upstream repo
git clone https://github.com/openclaw/skills
Claude Code · Install into ~/.claude/skills/
T=$(mktemp -d) && git clone --depth=1 https://github.com/openclaw/skills "$T" && mkdir -p ~/.claude/skills && cp -r "$T/skills/anderskev/swift-testing-code-review" ~/.claude/skills/openclaw-skills-swift-testing-code-review && rm -rf "$T"
OpenClaw · Install into ~/.openclaw/skills/
T=$(mktemp -d) && git clone --depth=1 https://github.com/openclaw/skills "$T" && mkdir -p ~/.openclaw/skills && cp -r "$T/skills/anderskev/swift-testing-code-review" ~/.openclaw/skills/openclaw-skills-swift-testing-code-review && rm -rf "$T"
manifest: skills/anderskev/swift-testing-code-review/SKILL.md
tags
#swift#testing#code-review#static-analysis#automation#linting
source content

Swift Testing Code Review

Quick Reference

Issue TypeReference
#expect vs #require, expression capture, error testingreferences/expect-macro.md
@Test with arguments, traits, zip() pitfallsreferences/parameterized.md
confirmation, async sequences, completion handlersreferences/async-testing.md
@Suite, tags, parallel execution, .serializedreferences/organization.md

Review Checklist

  • Expressions embedded directly in 
    #expect
    (not pre-computed booleans)
  • #require
    used only for preconditions, 
    #expect
    for assertions
  • Error tests check specific types (not generic 
    (any Error).self
    )
  • Parameterized tests with pairs use 
    zip()
    (not Cartesian product)
  • No logic mirroring implementation in parameterized expected values
  • Async sequences tested with 
    confirmation(expectedCount:)
  • Completion handlers use 
    withCheckedContinuation
    , not 
    confirmation
  • .serialized
    applied only where necessary (shared resources)
  • Sibling serialized suites nested under parent if mutually exclusive
  • No assumption of state persistence between 
    @Test
    functions
  • Disabled tests have explanations and bug links

When to Load References

  • Reviewing #expect or #require usage -> expect-macro.md
  • Reviewing @Test with arguments or traits -> parameterized.md
  • Reviewing confirmation or async testing -> async-testing.md
  • Reviewing @Suite or test organization -> organization.md

Review Questions

  1. Could pre-computed booleans in 
    #expect
    lose diagnostic context?
  2. Is 
    #require
    stopping tests prematurely instead of revealing all failures?
  3. Are multi-argument parameterized tests creating accidental Cartesian products?
  4. Could 
    zip()
    silently drop test cases due to unequal array lengths?
  5. Are completion handlers incorrectly tested with 
    confirmation
    ?