Claude-starter cleanup-types
Find duplicated or fragmented type/interface definitions across files and consolidate to a shared types module. TypeScript-first; also handles Python dataclasses/TypedDicts and Go structs. Use when the user asks to consolidate types, find duplicate interfaces, or organize type definitions.
git clone https://github.com/raintree-technology/claude-starter
T=$(mktemp -d) && git clone --depth=1 https://github.com/raintree-technology/claude-starter "$T" && mkdir -p ~/.claude/skills && cp -r "$T/skills/code-quality/cleanup-types" ~/.claude/skills/raintree-technology-claude-starter-cleanup-types && rm -rf "$T"
skills/code-quality/cleanup-types/SKILL.mdFind type definitions that should be shared but are duplicated across files. Consolidate into a single source of truth. Conservative by default — type consolidation looks safe but can hide intentional divergence.
Preflight
- Language detect: TS/JS (primary), Python (dataclass, TypedDict, Pydantic), Go (struct), Rust (struct/enum).
- Git state: refuse auto-apply on dirty tree.
- Report dir: ensure exists.
- Identify type homes: where does the project already keep shared types? Look for
,types/
,models/
, or a dedicated package (e.g.,schema/
,packages/types/
in monorepos).packages/db/src/schema/
Detect
No off-the-shelf tool reliably finds semantically equivalent types across languages. Use AST scanning + grep + structural comparison.
TypeScript
# Find every `interface Foo` and `type Foo =` declaration # Group by name, then by structural shape grep -rn --include="*.ts" --include="*.tsx" -E "^export (interface|type) [A-Z]" . > /tmp/ts-types.txt
For each name that appears in 2+ files, compare the shapes. Use
tsc --listFiles --noEmit output combined with the TypeScript compiler API if available, OR fall back to textual comparison after normalizing whitespace.
Python
# Find dataclass / TypedDict / Pydantic models grep -rn --include="*.py" -E "^(class \w+\(.*?(BaseModel|TypedDict)\)|@dataclass)" . > /tmp/py-types.txt
Go
grep -rn --include="*.go" -E "^type \w+ struct" . > /tmp/go-types.txt
Rust
grep -rn --include="*.rs" -E "^pub (struct|enum) \w+" . > /tmp/rust-types.txt
Cross-reference: for each type name, check if multiple files define it. For each pair, compare field-by-field.
Assess
Write
.claude/cleanup-reports/cleanup-types-{YYYY-MM-DD}.md:
# Type Consolidation Assessment — YYYY-MM-DD ## Summary - Type names with 2+ definitions: N - HIGH (structurally identical): X - MEDIUM (overlapping fields, may diverge intentionally): Y - LOW (same name, different meaning): Z ## Findings ### `User` interface — HIGH - Definitions: - `apps/app/features/auth/types.ts:8` — `{ id: string; email: string; createdAt: Date }` - `apps/admin/features/users/types.ts:12` — `{ id: string; email: string; createdAt: Date }` - Identical shape. Consolidate to `packages/db/src/schema/user.ts` (already has the runtime model). ### `Account` interface — MEDIUM - `domains/account/types.ts` — has 8 fields including `permissions: string[]` - `features/billing/types.ts` — has 5 of those 8 fields, no `permissions`. - Likely the billing one is a deliberate slice. Recommend: keep both, but rename billing's to `BillingAccount` for clarity. Don't auto-apply. ### `Config` type — LOW (different concepts) - `lib/api-config.ts` — API client config - `lib/feature-config.ts` — feature flag config - Same name, unrelated. Recommendation: rename one for clarity, but no consolidation. ## Critical Assessment [2-3 paragraphs: are types fragmented because there's no shared package, or because the architecture intentionally separates concerns?]
Apply
Auto-consolidate HIGH only. Type consolidation often crosses package boundaries and reshapes import graphs — be conservative.
Confidence rubric
HIGH (auto-apply):
- Same type name in 2+ files.
- Field names, types, and modifiers (optional, readonly) all match exactly.
- Same semantic concept (verify by usage — both used for the same domain entity).
- Existing shared types module exists in the workspace.
MEDIUM (report only):
- Overlapping fields with intentional divergence (one has extras, one omits some).
- Same shape but different name — could be a renaming opportunity, but choosing the canonical name is judgment.
- Cross-package consolidation that requires creating a new shared package.
LOW (note only):
- Same name, different meaning (Config, Options, Result are common offenders).
- Generated types (from OpenAPI, GraphQL, Drizzle schema, etc.) — leave the codegen alone.
Execution (HIGH only)
- Choose canonical home: existing shared types module that both source files can import.
- Move the type definition there (preserve JSDoc/comments).
- Replace both originals with
.import type { Foo } from '...' - Run typecheck — if any error appears (often due to nominal typing differences in TS, or generic param mismatches), revert that one and downgrade.
- Commit:
.chore(cleanup): cleanup-types — consolidated N duplicate type definitions
Verify
# Typecheck is the critical signal npm run typecheck 2>&1 || npx tsc --noEmit mypy . 2>&1 || true go build ./... 2>&1 cargo check 2>&1 # Then standard test/lint npm test && (npx @biomejs/biome check . || npx eslint .)
Type consolidation that breaks downstream usage (e.g., a consumer relied on a field being
optional in one definition but required in the other) shows up here. Revert on any new error.
Output
- "Consolidated N duplicate type definitions. M deferred for review."
- Report path.
- Verify status.
NEVER
- Auto-consolidate generated types (Drizzle inferred types, OpenAPI codegen, Prisma types, GraphQL schema types) — regenerate is the right answer.
- Merge a
from a public-API package with aFoo
from a private app package — that breaks the API contract.Foo - Create a new shared package automatically.
- Consolidate types that have nominal markers (branded types, opaque types) — those exist precisely to not be merged.
- Touch types in
ambient declaration files unless the source is also a*.d.ts
..d.ts - Auto-rename — renaming has cascading effects and needs human sign-off.